fix: mark Boxed Future as Send #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decrypt_chunk function is a function used by many higher level functions and crates. Without specifying the Send constraint, all async functions relying on this function will be non-Send. This shouldn't be dangerous, as the Boxed Future is actually Send-able as witnessed by the fact the compiler does not complain.
|
ah nice one @b-zee ! |
joshuef
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decrypt_chunk function is a function used by many higher level
functions and crates. Without specifying the Send constraint, all
async functions relying on this function will be non-Send.
This shouldn't be dangerous, as the Boxed Future is actually Send-able
as witnessed by the fact the compiler does not complain.
Should fix:
maidsafe/safe_network#62
https://github.com/maidsafe/sn_client/issues/1555